New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize performance #9

Closed

dtopuzov wants to merge 1 commit into gyoshev:master from dtopuzov:master

dtopuzov commented Apr 23, 2021

Changes:

Do now always wait 200ms
Update to Selenium 4

Test Results:

Tested with 200 images on my local machine
Before those changes, it took ~65sec
After those changes, it takes less than 40sec


          chore: optimize performance

d07b7ab

- Do now always wait 200ms
- Update to Selenium 4

Author

dtopuzov commented Apr 23, 2021

Looks buggy, will close it.
In general, the idea is still valid - do not hardcode 200ms wait, use smaller wait steps and retry in case of failure.

dtopuzov closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet