Include wasm-shim files in cargo package #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agggh cargo package... |
|
Are the failing tests on |
|
It's just the windows VM using outdated GCC, and my hack to update it in CI isn't fully working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the released
0.11does not work forwasm32-unknown-unknown, while the build does work for the same revision from Git.In the process of making an example (https://github.com/kylebarron/zstd-rs-wasm-bug-example), I realized the shim files were likely not included in the release.
cargo package --listinzstd-sysconfirmed that previously thewasm-shimfiles were not included in the build.