feat: sign with keyless approach #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
force-pushed
the
feature/71
branch
from
630137b
to
a05f824
Compare
cpanato
requested changes
Jan 17, 2022
There was a problem hiding this comment.
looks cool
can you change here as well https://github.com/gythialy/golang-cross/blob/main/.github/workflows/builder.yml#L41 we sign the builder image too :)
developer-guy
force-pushed
the
feature/71
branch
from
a05f824
to
02ee893
Compare
Thanks, @cpanato, you always have my back. 🤝 |
cpanato
requested changes
Jan 18, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/71
branch
from
02ee893
to
ac2d0b4
Compare
cpanato
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Fixes #71