Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More idiomatic Rust :)
Split channel sender and receiver into two clear owners.
Replace sync crossbeam with async tokio channels, so we don't hold a
synchronous lock over async await.
Simplify applier start/stop lifecycle with RAII pattern (could do more here).
Pass owned
echo::Manager
toapply_async
rather thanArc
reference.Use
?
operator and early-return to refactor some deeply nested code,particularly in
server::handle_request
.Notifier
: Replace asyncRwLock<>
with simpler syncArc<Mutex<>>
because these locks don't need to be held over async await.
echo::Manager
: Use ownership (&mut
) to assert mutual exclusionrather than a lock.
echo::Request
: Treat omittedmessage
as equivalent tomessage == ""
, to better match golangomitempty
semantics.