Use the core::arch intrinsics where possible #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Sep 4, 2018
gz
reviewed
Sep 4, 2018
GabrielMajeri
force-pushed
the
core-arch
branch
from
14b9907
to
4495f13
Compare
|
I've opened rust-lang/stdarch#559 to track the issue with For now, this PR will use |
|
Sounds good, thanks for the pull request. |
Ericson2314
reviewed
Sep 5, 2018
|
|
||
| asm!("rdtsc" : "={eax}" (low), "={edx}" (high)); | ||
| ((high as u64) << 32) | (low as u64) | ||
| mem::transmute(_rdtsc()) |
There was a problem hiding this comment.
Isn't it much better to use as u64 for this sort of thing?
There was a problem hiding this comment.
It is... It's fixed on master now thanks for raising this concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of some intrinsics in
core::archmeans that we no longer have to use inline assembly in some cases.I've changed
rdtsc's signature to match the one incore::arch& Intel's docs.Please tell me if there's some other
core::archfunction which I've missed and we could use it in this crate.