Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After release of the first HDI (or integrity kit) of Holochain, update versions to that #275

Closed
Connoropolous opened this issue May 24, 2022 · 6 comments · Fixed by #340
Closed
Assignees

Comments

@Connoropolous
Copy link
Contributor

Connoropolous commented May 24, 2022

here is an example to sample from:
https://github.com/perspect3vism/agent-language/tree/main/hc-dna/zomes/tests

@pospi
Copy link
Member

pospi commented Jul 2, 2022

This will be quite an extensive refactor- we will need to update all the index handling logic to use split integrity/coordination zomes to manage the updates via post_commit hooks. In doing so it is hoped that such cascading updates can be handled more gracefully, and debug! statement related to indexing removed.

We may also have to update tests unrelated to Agent data but featuring Agent links to actually create the agents in question. Currently the indexing situation swallows / ignores many CellMissing errors that are related to mocked AgentAddresses.

@Connoropolous
Copy link
Contributor Author

Connoropolous commented Jul 20, 2022

"we will need to update all the index handling logic to use split integrity/coordination zomes to manage the updates via post_commit hooks. In doing so it is hoped that such cascading updates can be handled more gracefully, and debug! statement related to indexing removed."

This sounds like added scope. Unless I'm missing something which is very possible, this sounds like something unnecessary to do at this same time. Can we trim back this scope to only the update?

I am thinking of targeting HDK 0.0.142
HDI 0.0.14

And thats Holochain 0.0.150

@Connoropolous
Copy link
Contributor Author

"We may also have to update tests unrelated to Agent data but featuring Agent links to actually create the agents in question. Currently the indexing situation swallows / ignores many CellMissing errors that are related to mocked AgentAddresses."

I also don't think we will have to do this.

@pospi
Copy link
Member

pospi commented Jul 21, 2022

Yeah, two phases for these updates I think.

@Connoropolous
Copy link
Contributor Author

@pospi I've started this, and have assigned it to myself for now, but am also happy to collaborate on it, we would just need to coordinate our actions.

@Connoropolous
Copy link
Contributor Author

There is this one to review: holochain-open-dev/dna-auth-resolver#3
and this one is up and just getting started in draft: #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants