Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up some nice default queries in hrea-graphql-explorer #314

Merged
merged 5 commits into from
Jun 30, 2022
Merged

set up some nice default queries in hrea-graphql-explorer #314

merged 5 commits into from
Jun 30, 2022

Conversation

Connoropolous
Copy link
Contributor

No description provided.

@Connoropolous Connoropolous self-assigned this Jun 29, 2022
pospi
pospi reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@pospi pospi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good starting point, but I might check to see if we can inject comments into the explorer as well as it will give folks a better idea. If not, I will merge.

@pospi
added comments into the default queries to make them read as more of …
18d3dfd 
…a tutorial, also added inventorying since it is often a point of confusion
@pospi
Copy link
Member

pospi commented Jun 29, 2022

Put in some things but need to fix #315 in order to try them out.
If there are issues, we can revert 18d3dfd

@Connoropolous
Copy link
Contributor Author

Connoropolous commented Jun 29, 2022 •
edited
Loading

There should be a button to close the error overlay in the top right. I'm not saying thats a fix, but at least you can try what you added. And this PR didn't introduce the bug so we can also merge this and then separately I will tackle the bug, which will technically just mean talking with Jost and asking them for a fix I think.

@Connoropolous
Copy link
Contributor Author

@weswalla what do you think of this?
https://github.com/h-REA/hREA/pull/314/files#diff-22dcc3518890718f62f83a0abc86885d1fd9c0a94511afe5306c34b030586f8d

@Connoropolous Connoropolous changed the title set up some nice deafult queries in hrea-graphql-explorer set up some nice default queries in hrea-graphql-explorer Jun 29, 2022
@Connoropolous Connoropolous reopened this Jun 29, 2022
@pospi
Copy link
Member

pospi commented Jun 30, 2022

have run through all this locally now, and works a charm

@pospi pospi merged commit 23927b0 into sprout Jun 30, 2022
@pospi pospi deleted the update-default-query branch June 30, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pospi pospi pospi left review comments

@weswalla weswalla Awaiting requested review from weswalla

Assignees

@Connoropolous Connoropolous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Connoropolous @pospi