-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query all endpoint resolvers #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting that #327 is mentioned here
@weswalla I am running the tests locally and reviewing |
@weswalla I just pushed a fix for the 'seralizeId' ones |
wow, on one test I am getting an error that is a 60 second timeout on a zome call. Crazy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the main thing I mis-scoped here was Agent. Perhaps it's right than in this case we shouldn't oversimplify. Let's adjust course slightly a make it more robust.
#327 (comment)
…of read_all_agents in gql layer
…zations separately
@Connoropolous @pospi is #330 still in scope of this PR? |
I think we can split that one out if you're eager to get this merged. If I have time today I'll try to keep going and make it work in addition to the |
…slation at client layer so that internals of indexing lib can remain *Addressable-based
…nslation logic away
…ndexed units by *Address
More flexible index macros to allow String-based identifiers for agent_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking all good, minus a few superficial artifacts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are passing and the little cleanup things I've done. merging!
closes #320