Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query all endpoint resolvers #326

Merged
merged 36 commits into from
Jul 8, 2022
Merged

Conversation

weswalla
Copy link
Contributor

@weswalla weswalla commented Jul 4, 2022

closes #320

@weswalla weswalla changed the title query all enpoint resolvers query all endpoint resolvers Jul 4, 2022
Copy link
Contributor Author

@weswalla weswalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting that #327 is mentioned here

@Connoropolous
Copy link
Contributor

@weswalla I am running the tests locally and reviewing

@Connoropolous
Copy link
Contributor

@weswalla I just pushed a fix for the 'seralizeId' ones

@Connoropolous
Copy link
Contributor

wow, on one test I am getting an error that is a 60 second timeout on a zome call. Crazy

Copy link
Contributor

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the main thing I mis-scoped here was Agent. Perhaps it's right than in this case we shouldn't oversimplify. Let's adjust course slightly a make it more robust.
#327 (comment)

@weswalla
Copy link
Contributor Author

weswalla commented Jul 7, 2022

@Connoropolous @pospi is #330 still in scope of this PR?

@pospi
Copy link
Member

pospi commented Jul 8, 2022

I think we can split that one out if you're eager to get this merged. If I have time today I'll try to keep going and make it work in addition to the agent_type. If not, feel free to merge this and we can make a followup PR later.

Copy link
Contributor

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking all good, minus a few superficial artifacts!

modules/vf-graphql-holochain/queries/agent.ts Outdated Show resolved Hide resolved
modules/vf-graphql-holochain/queries/agent.ts Outdated Show resolved Hide resolved
modules/vf-graphql-holochain/queries/agent.ts Outdated Show resolved Hide resolved
test/process/process_records_e2e.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are passing and the little cleanup things I've done. merging!

@Connoropolous Connoropolous merged commit 2225b30 into sprout Jul 8, 2022
@Connoropolous Connoropolous deleted the read-all-endpoint-resolvers branch July 8, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define graphql resolvers for remaining 'read all' endpoints
3 participants