-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fulfillment & satisfaction APIs #59
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AD handlers, optimise memory handling for fulfillments
…ing not supported
…holochain/holochain-rust#1677 Not happy about this commit... ideally it can be reverted someday.
…g params via 'call' through zome gateways
…diary link records
…I to take named params
This was referenced Sep 2, 2019
I know you're all on the road right now so I'm going to self-merge this so that @philipbeadle & other devs can get started on an up-to-date system this/next week (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly focused on completing #42 and passing end-to-end integration tests for both
Fulfillment
andSatisfaction
-related functionality. It includes everything needed for a working first-pass at all flow records (these plusEconomicEvent
,Commitment
andIntent
) and has full support in GraphQL for the related "read by ID" and relationship traversal queries.It also adds the following updates:
MaybeUndefined
to allow for serialisation & request passingTo do:
There are a few additional cleanup tasks added to #39 - nothing major, just cleanup. My goal is to get the base system passing integration tests ASAP so that others can start developing on it before we make a serious optimisation pass. We also need to think through what we have so far and sound out any worthwhile improvements before continuing on to other modules besides observation, planning & specification.
This work also opens up some other avenues for exploration around creating shared abstractions for storing link metadata. It is quite likely that adopting an XDI format as a base for records like
Fulfillment
andSatisfaction
would be beneficial for interoperability with projects like the Link Index DNA.It may also be worth investigating the Holochain signalling API more as a followup- see #57.