Refactor filter code structure and unit tests #64

h-dong · 2023-01-31T01:59:14Z

Changes:

Created Filter class to abstract away more code and reduce tests required at each filter level.
Shifted tests to Regex constants files instead of at the filter entry point. This will hopefully simplify testing and catch more bugs.
Refactored and pretty much re-written all the unit tests again, borrowing from previous test cases when possible.
Fixed a number of bugs which was missed previously.
Added an edge case into README.
Regex clean up and improvements.

If the current date is Jan 30th, trying to set it to Feb 17th has a logic error. It will first set the month first, which becomes Feb 30th since Feb doesn't have 30 days, it gets converted to March 2nd. Then set day kicks into effect, and changes from March 2nd to March 17th.

h-dong added 20 commits January 21, 2023 09:57

Clean up regex partials

464b55d

Remove unnecessary comment

8196795

Rename weekDay to weekday

f9d1f84

Code clean up

50e5029

Refactor year tests

43ea33a

Add quotes around test.each variables

5b3b58c

Refactor day filter

0467da2

Refactor month filter

744513f

Refactor weekday and other clean ups

d7da70f

Refactor weeday and time filter

19ad8ac

Refactored timeKeywords

a00597e

Partial commit of a few refactors

5230faf

Add missing word boundary config

d1161cd

Remove space in test descriptions

bf35b2b

Finish refactoring partial dates

ab751c6

Finished refactoring relative dates

d3201cc

Finished refactoring time filter

b1a5c2a

Fix more broken tests

a33f121

Fix all remaining tests

4298da0

h-dong changed the title ~~Refactor/clean-up-regex~~ Refactor filter code structure and unit tests Jan 31, 2023

h-dong added 8 commits January 31, 2023 02:04

Remove unnecessary tests

37c3575

Rename to weekday2 to be renamed back

ab405ad

Rename back for linux to pick up the name change

651efb6

Test file tidy up

8b322cc

Rename WeekdayAndTime, to be renamed back

4560686

Rename hopefully linux picks up the rename

57b65f3

Fix wrong test assertions

5407f1d

Update unit test assertion to make it pass locally

4adc3c8

h-dong merged commit abb0d12 into master Jan 31, 2023

h-dong deleted the refactor/clean-up-regex branch January 31, 2023 02:52

This was referenced Jan 31, 2023

Refactor 7 lines occurring 2 times in 2 files: dates.ts, time.ts #21

Closed

Make filter classes into either OOP or functional #36

Closed

Combine utils function into single file #37

Closed

Use Jest Each instead of custom test case #15

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor filter code structure and unit tests #64

Refactor filter code structure and unit tests #64

h-dong commented Jan 31, 2023 •

edited

Loading

Refactor filter code structure and unit tests #64

Refactor filter code structure and unit tests #64

Conversation

h-dong commented Jan 31, 2023 • edited Loading

h-dong commented Jan 31, 2023 •

edited

Loading