Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes scrollbar in code blocks #231

Merged
merged 4 commits into from
Jun 14, 2021
Merged

🐛 Fixes scrollbar in code blocks #231

merged 4 commits into from
Jun 14, 2021

Conversation

OCram85
Copy link
Contributor

@OCram85 OCram85 commented Apr 13, 2021

📦 Content

  • Increases contrast for horizontal scrollbar in pre code blocks
  • adds matching scss definition for code blocks in dark mode

I'm not sure if i found all relevant css definitions, or used the preexisting scss variables / color definition

🔖 Refs

@OCram85 OCram85 changed the title Fix scrollbar Fixes scrollbar in code blocks Apr 13, 2021
@OCram85
Copy link
Contributor Author

OCram85 commented Apr 13, 2021

btw what is the meaning of this block in assets/scss/components/_docs.scss:

.hljs {
  display: block;
  overflow-x: auto;
  padding: 0.5em;
  background: $beige;
  color: $body-color;
}

I tried to disable the background and color property to get this form the highlight.js themes. But even if there is no active theme or highlight enabled, the colors are still active. So these 2 properties could be removed, too ?

@OCram85 OCram85 changed the title Fixes scrollbar in code blocks 🐛 Fixes scrollbar in code blocks Apr 15, 2021
@h-enk
Copy link
Member

h-enk commented Apr 19, 2021

So these 2 properties could be removed, too ?

Yeah, you're absolutely right.

@h-enk
Copy link
Member

h-enk commented Apr 19, 2021

Tested /verified your scrollbar fix — nice + thanks!

@h-enk h-enk merged commit de94e5a into gethyas:master Jun 14, 2021
@OCram85 OCram85 deleted the fixScrollbar branch July 20, 2021 06:21
adhadse pushed a commit to adhadse/doks that referenced this pull request Sep 17, 2022
🐛 Fixes scrollbar in code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight.js horizontal scroll bar disappears in dark mode
2 participants