Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented VaultClientAPIs #14

Open
Hoikas opened this issue Apr 17, 2011 · 3 comments
Open

Unimplemented VaultClientAPIs #14

Hoikas opened this issue Apr 17, 2011 · 3 comments

Comments

@Hoikas
Copy link
Member

Hoikas commented Apr 17, 2011

There are a lot of "eric, implement me" and "eric, port me" assertions in plVaultClientApi. We should really implement these because (in some cases) pfPython uses some of this unimplemented functionality. When implementing them, we should really try not to block. Already entirely too much of the vault API blocks, which is responsible for most of the freezes in the client.

@Hoikas
Copy link
Member Author

Hoikas commented Oct 13, 2023

This may be addressed by #1486 by simply deleting the unimplemented stuff.

@dpogue
Copy link
Member

dpogue commented Oct 13, 2023

There are still a few "eric, implement me" assertions, although arguably that's probably an indicator that the function isn't being used

@dgelessus
Copy link
Contributor

Had a quick look over the remaining ones. A few that stand out to me:

  • NetCliAuthVaultNodeDelete is impossible to implement with the existing network protocol, because the Cli2Auth_VaultNodeDelete message is undefined
  • VaultSetNodeSeen is challenging, as described in KI Incoming read/unread status is broken #1246
  • VaultFindOrCreateChildAgeLinkAndWait is unimplemented, unused, and blocking - that can definitely go
  • The age chronicle stuff could be useful if implemented - IIRC, some age Python scripts currently do this by hand

The other ones seem to be for things that no longer exist (e. g. age czars) or are implemented elsewhere now (e. g. KI levels and CCR petitions). Those probably aren't worth restoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants