feat(matchers): Add custom body type matcher #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add the custom body type matcher that was proposed in #87
The logic is pretty simple - If a user passes a non-empty mime type to the BodyType function, then the
Content-Type
header on the http request must be the same for there to be a match. If there's no mime type passed then it falls back to the the existing logic of checking against the hardcoded list of supported mime types.One thing I'm a bit unsure of - I discovered
MatchType
and now I feel like adding this additional method will be confusing to people, since there will be two separate methods for matching based on theContent-Type
header but the behaviour is different.@h2non Any thoughts on this?