Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new function ptls_get_read_epoch to return current read epoch #177

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Aug 13, 2018

For example, the function will return 1 until it receives full EOED when 0-rtt is active. It can be used by the QUIC stacks to determine when it should supply epoch 2 crypto data to picotls.

fixes #175

…, `1` while picotls expects to receive (part of) EOED
Copy link
Collaborator

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yes. I like the idea of checking before calling the handle message function. That way there is no need to keep TLS state in the QUIC stack.

@kazuho kazuho merged commit 5026901 into master Aug 14, 2018
@kazuho
Copy link
Member Author

kazuho commented Aug 14, 2018

Thank you for the review!

@huitema
Copy link
Collaborator

huitema commented Aug 14, 2018

Thanks. I just implemented the call to ptls_get_read_epoch() in Picoquic, replacing my previous kludge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delay passing handshake read key to QUIC until receiving EOED
2 participants