This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7d855e
to
3e43996
Compare
2d2edc1
to
61eb732
Compare
3e43996
to
fc72611
Compare
61eb732
to
65bc3bb
Compare
fc72611
to
dd1cc1c
Compare
f17c36b
to
6d0c2dd
Compare
mmalohlava
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osery looks good.
Here are a couple of quick pointers and things to consider
- Here is a link to an API spec we have been considering for scoring, this just FYI https://github.com/h2oai/h2oai/blob/69ac746dda5977bfdaeeac4394d17bd1dc1de713/h2oai_scorer/scoring-pipeline/rest_server/swagger.yaml
- When a model is deployed for scoring, how do you know what the API end-point is?
- I am assuming when multiple models are deployed there will be separate API end-points? If the API cannot be queried to know which model it is scoring it may become tricky quickly when you have more than one model
- how is an API unpublished? assuming it easy to create and deploy models, will there be lots of dormant APIs?
- assuming this is over the internet some minimum authentication mechanism for the API may be a good idea
Thanks a lot @chandanmaruthi. Great comments.
|
chandanmaruthi
approved these changes
Nov 19, 2018
Wip on #2721.
6d0c2dd
to
7f0f79f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wip on #2721.