Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MaxRSweep run time #6949

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments
Closed

Improve MaxRSweep run time #6949

exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments
Assignees

Comments

@exalate-issue-sync
Copy link

No description provided.

@exalate-issue-sync
Copy link
Author

Wendy Wong commented: Current maxrsweep tries to us less memory for smaller predictor subsets. However, this makes the runtime unpredictable.

@exalate-issue-sync
Copy link
Author

Wendy Wong commented: I tried many different methods:

1 Use full memory;

  1. save the CPMs and sweep vectors instead of generating it all the time.

However, nothing beats the original maxrsweep implementation. I was able to provide extra speedup by:

not using GLM to build a final GLM model. Just extract the coefficients and R2 value from CPm matrix;

do not allocate matrix in sweeping with sweep vectors.

I also fix the order of predictor subsets for maxrsweep so that it is in order and not scrambled.

!image-20221019-184619.png|width=947,height=409!

!image-20221019-184633.png|width=1122,height=732!

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8785
Assignee: Wendy Wong
Reporter: Wendy Wong
State: Resolved
Fix Version: 3.38.0.2
Attachments: Available (Count: 3)
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Attachments From Jira

Attachment Name: image-20221019-184619.png
Attached By: Wendy Wong
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8785/image-20221019-184619.png

Attachment Name: image-20221019-184633.png
Attached By: Wendy Wong
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8785/image-20221019-184633.png

Attachment Name: SweepMaxR.pdf
Attached By: Wendy Wong
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8785/SweepMaxR.pdf

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6280
https://github.com/h2oai/h2oai-serving/pull/1112

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants