-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MaxRSweep run time #6949
Comments
Wendy Wong commented: Current maxrsweep tries to us less memory for smaller predictor subsets. However, this makes the runtime unpredictable. |
Wendy Wong commented: I tried many different methods: 1 Use full memory;
However, nothing beats the original maxrsweep implementation. I was able to provide extra speedup by: not using GLM to build a final GLM model. Just extract the coefficients and R2 value from CPm matrix;do not allocate matrix in sweeping with sweep vectors.I also fix the order of predictor subsets for maxrsweep so that it is in order and not scrambled. !image-20221019-184619.png|width=947,height=409! !image-20221019-184633.png|width=1122,height=732! |
JIRA Issue Details Jira Issue: PUBDEV-8785 |
Attachments From Jira Attachment Name: image-20221019-184619.png Attachment Name: image-20221019-184633.png Attachment Name: SweepMaxR.pdf |
Linked PRs from JIRA |
No description provided.
The text was updated successfully, but these errors were encountered: