Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguity check in explain's consolidate varimp #7014

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Closed

Fix ambiguity check in explain's consolidate varimp #7014

exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments

Comments

@exalate-issue-sync
Copy link

In very rare cases we can encode multiple categorical variables to new one hot encoded variables that have the same name. The part of code in explain that was supposed to check for the ambiguity was broken.

Consider the following data frame:

{code:none} a | a.b
----+-----
b.c | c
d | d{code}

when one hot encoding it we would end up with two variables named {{a.b.c}} which could cause issues in the consolidate varimp part of code.

@exalate-issue-sync exalate-issue-sync bot added the R label May 11, 2023
@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8682
Assignee: Tomas Fryda
Reporter: Tomas Fryda
State: Resolved
Fix Version: 3.36.1.2
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants