Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tone in warning message about H2O version being too old #7294

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments
Closed

Change tone in warning message about H2O version being too old #7294

exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments

Comments

@exalate-issue-sync
Copy link

Regarding the “too old” message — I know we want to encourage people to update h2o, but i wonder if there’s a better way to phrase it? “too old” with exclamation seems very intense and may alarm people, and a lot of people can’t update for various reasons. Sometimes, it’s just because we have not released a new version, and sometimes its because they trained some models in an old version, etc.

It looks like we display this message after only [100 days|https://github.com/h2oai/h2o-3/blob/879e58d3e5f98064b738189febecd845bf4f87c4/h2o-core/src/main/java/water/init/AbstractBuildVersion.java#L16]. The message itself is [here|https://github.com/h2oai/h2o-3/blob/aa6948fac8cddf40293c8177bf87ec9a175e7a2b/h2o-core/src/main/java/water/H2O.java#L1831].

Current warning messages, and !!! in H2O cluster version age:

{code:r}R is connected to the H2O cluster:
H2O cluster uptime: 1 seconds 804 milliseconds
H2O cluster timezone: America/Los_Angeles
H2O data parsing timezone: UTC
H2O cluster version: 3.32.1.3
H2O cluster version age: 4 months and 10 days !!!
H2O cluster name: H2O_started_from_R_ledell_piu057
H2O cluster total nodes: 1
H2O cluster total memory: 22.70 GB
H2O cluster total cores: 40
H2O cluster allowed cores: 40
H2O cluster healthy: TRUE
H2O Connection ip: localhost
H2O Connection port: 54321
H2O Connection proxy: NA
H2O Internal Security: FALSE
H2O API Extensions: Amazon S3, XGBoost, Algos, AutoML, Core V3, TargetEncoder, Core V4
R Version: R version 3.4.4 (2018-03-15)

Warning message:
In h2o.clusterInfo() :
Your H2O cluster version is too old (4 months and 10 days)!
Please download and install the latest version from http://h2o.ai/download/{code}

Perhaps we can do something like:

{code:r}Your H2O cluster version is 4 months and 10 days old. There may be a newer version available.
Please download and install the latest version from http://h2o.ai/download/{code}

@exalate-issue-sync
Copy link
Author

Erin LeDell commented: [~accountid:5c9943ec3a5542225fedb6b9] I saw you changed the fix release to 3.40.01. This PR is for rel-zygmund, can I put the “fix release” to 3.38.0.5, or do you want this in the next major? Thx.

@exalate-issue-sync
Copy link
Author

Marek Novotny commented: Hi [~accountid:557058:afd6e9a4-1891-4845-98ea-b5d34a2bc42c] ,
I’ve changed the fix release of this PR since its original value was 3.38.0.4, which has been released already. According to information that I have, It doesn’t seem that we will do another fix release before 3.40.0.1 and that’s the reason why I changed the value to 3.40.0.1. You can still merge the PR to rel-zygmund (it will get propagated to master) and if anything changes I will change the fix release to 3.38.0.5.

@exalate-issue-sync
Copy link
Author

Erin LeDell commented: Thanks [~accountid:5c9943ec3a5542225fedb6b9] yeah that was a mistake (3.38.0.4)… 😅

@h2o-ops-ro
Copy link
Collaborator

JIRA Issue Details

Jira Issue: PUBDEV-8363
Assignee: Erin LeDell
Reporter: Erin LeDell
State: Resolved
Fix Version: 3.40.0.1
Attachments: N/A
Development PRs: Available

@h2o-ops-ro
Copy link
Collaborator

Linked PRs from JIRA

#6475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants