Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: remove algo-specific logic from base classes #7476

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Closed

Python: remove algo-specific logic from base classes #7476

exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Labels
fixVersion/3.34.0.1

Comments

@exalate-issue-sync
Copy link

{{H2OEstimator}}, {{ModelBase}} and other generic classes contain algo-specific logic (as if-else conditions).

We need to refactor that and ensure that each estimator and model gets injected only the features it supports.
@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8174
Assignee: Sebastien Poirier
Reporter: Sebastien Poirier
State: Resolved
Fix Version: 3.34.0.1
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#5516

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixVersion/3.34.0.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h2o-ops