-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone R client #7782
Comments
Erin LeDell commented: [~accountid:5c355702a217aa69bce55831] I am not sure I understand what the advantage is of not downloading the jar is. It’s not that big of a file and only takes a few seconds to download…? This sounds like it would add complexity to our release process for little gain, or maybe it will make more sense when you explain the value. The normal Python client includes the jar though, right? I am not aware that we have a Python equivalent of this. |
Joseph Granados commented: In the hadoop downloads theres {noformat}123M Jul 21 11:16 h2o-3.30.0.7-py2.py3-none-any.whl I wouldn’t say the whl with the jar is small. However the main advantage is that it forces users to use connect to an already running cluster on hadoop instead of accidentally launching a local cluster. This is an issue our hadoop r users run into. |
Erin LeDell commented: [~accountid:5c355702a217aa69bce55831] I think that second file will just download the H2O jar, just like R, no? Thanks for clarifying what the issue that this is trying to solve is (that users are not connecting to the hadoop cluster). Even if we have a lightweight version which does not have a local jar, the default settings of {{h2o.init()}} will still try to connect to a local cluster. If there’s no jar to start, then it will give some error (which might not be very helpful if they don’t already know that they were supposed to connect to a remote hadoop cluster in {{h2o.init()}}. I wonder if there’s another way to solve this – i guess there’s no way we could automatically detect whether or not they would want to connect to a hadoop cluster, right? |
Joseph Granados commented: The second whl doesn’t download anything. If there’s an error that’s okay. Another part of the issue right now is when the h2o library is loaded in R it immediately prints a message telling the user to run {{h2o.init()}}, (which they usually do even if they have instructions otherwise) which is the wrong thing to do when connecting to a hadoop cluster. {{h2o.connect()}} is used instead of {{h2o.init()}} : [http://docs.h2o.ai/enterprise-steam/latest-stable/docs/r-docs/articles/h2osteam.html|http://docs.h2o.ai/enterprise-steam/latest-stable/docs/r-docs/articles/h2osteam.html] |
Erin LeDell commented: [~accountid:5c355702a217aa69bce55831] Would it help if we updated the print-out from {{h2o.init()}} to say something like: “Your next step is to start H2O using h2o.init() or connect to an existing cluster using h2o.connect().” It probably hasn’t been updated in years and could probably use a refresh. Here’s the current state: !Screen Shot 2020-10-29 at 2.58.08 PM.png|width=678,height=615! |
Adam Valenta commented: H2O distribution zip archive will contain also h2o_client${PROJECT_VERSION}.tar.gz file under R folder, with client version of R package. Similarly to client python package, the client package is not contain full h2o.jar and does not suggest to call h2o.init() but h2o.connect() instead. |
Joseph Granados commented: [~accountid:5f8e6929461cc40075215ee0] not a big deal, but could we add an underscore separating the name and project version like so: h2o_client_${PROJECT_VERSION}.tar.gz |
Joseph Granados commented: In python, if you call {{h2o.init()}} the message {{Error Output:}} |
Adam Valenta commented: Yes, I’ll check it |
Joseph Granados commented: Also, maybe I’m doing something wrong but I don’t see the message when I import the library. Which I think is fine, just wanted to make sure that’s expected. This is the message I don’t get anymore in R Studio: !Screen Shot 2020-10-29 at 2.58.08 PM (012f8f10-6342-4732-96e9-09b1945382a3).png|width=678,height=615! |
Adam Valenta commented: It is weird, did you install client package to the clean workspace? |
Joseph Granados commented: I restarted R and the message is now there. |
Joseph Granados commented: Maybe “Your next step is to start H2O:” should be changed to “Your next step is to connect to H2O:”. |
Adam Valenta commented: Sure, is it is still trying to connect with clean workspace? |
Joseph Granados commented: Yes. |
Adam Valenta commented: h2o_client_${PROJECT_VERSION}.tar.gz (/) The connection actually worked analogically to python, the difference is that R is waiting for 60s to tell you what is wrong. The current PR is changing the behavior to prevent starting and give the message directly. (/) [https://github.com//pull/5184|https://github.com//pull/5184|smart-link] |
JIRA Issue Migration Info Jira Issue: PUBDEV-7861 Linked PRs from JIRA Attachments From Jira Attachment Name: Screen Shot 2020-10-29 at 2.58.08 PM.png Attachment Name: Screen Shot 2020-10-29 at 2.58.08 PM (012f8f10-6342-4732-96e9-09b1945382a3).png |
Offer a standalone R client (the same way we have a python one) that:
This will be useful for Steam installs where h2o isn't running on the same machine as the client.
The text was updated successfully, but these errors were encountered: