Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBDEV-7721: Add documentation for the new GAM hyperparameter: subspaces #4844

Merged
merged 4 commits into from
Aug 31, 2020

Conversation

hannah-tillman
Copy link
Contributor

Please let me know if you would like me to change anything.

Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hannah-tillman.
I'm just blocking this until we agree on the name constraints vs params_grouping vs. ...
and also waiting for PR #4742 to be approved and merged.

Co-authored-by: Seb <sebastien@h2o.ai>
h2o-docs/src/product/data-science/gam.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/grid-search.rst Show resolved Hide resolved
@hannah-tillman hannah-tillman changed the title Add documentation for the new GAM hyperparameter: constraints PUBDEV-7721: Add documentation for the new GAM hyperparameter: constraints Aug 27, 2020
Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more renaming suggestions, then we're good to go.

h2o-docs/src/product/data-science/gam.rst Outdated Show resolved Hide resolved
h2o-docs/src/product/data-science/gam.rst Outdated Show resolved Hide resolved
@hannah-tillman hannah-tillman changed the title PUBDEV-7721: Add documentation for the new GAM hyperparameter: constraints PUBDEV-7721: Add documentation for the new GAM hyperparameter: subspaces Aug 31, 2020
@hannah-tillman hannah-tillman merged commit c18e89e into rel-zeno Aug 31, 2020
@hannah-tillman hannah-tillman deleted the PUBDEV-7721 branch August 31, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants