PUBDEV-8024: Allow to use user given fold column where not all folds are represented #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkurka
force-pushed
the
michalk_flexible-folds
branch
3 times, most recently
from
fa80a9f
to
f2728d9
Compare
sebhrusen
reviewed
Feb 24, 2021
michalkurka
force-pushed
the
michalk_flexible-folds
branch
from
4176580
to
237172b
Compare
|
@seb please take another look, I simplify it so that for "internal" fold there is no mapping created I am also using TransformWrappedVec to avoid propagating the mapping to the outside world |
michalkurka
force-pushed
the
michalk_flexible-folds
branch
from
237172b
to
74ebad5
Compare
michalkurka
force-pushed
the
michalk_flexible-folds
branch
from
74ebad5
to
4cb1c1f
Compare
michalkurka
force-pushed
the
michalk_flexible-folds
branch
from
4cb1c1f
to
6b76456
Compare
|
@sebhrusen thank you for the review and for pushing me in the right direction, I think it is now cleaner and it doesn't leak the implementation details outside of FoldAssignment |
michalkurka
changed the title
michalkurka
pushed a commit
that referenced
this pull request
Mar 23, 2021
We changed the way cv folds are assigned in #5345 This affects fold specification that doesn't start from 0, eg. 1, 2, 3 Old way was to use modulo operator resulting in effective fold assignment: 1, 2, 0 New way is to respect the fold order, resulting in fold assignment 0, 1, 2
flaviusburca
pushed a commit
to mware-solutions/h2o-3
that referenced
this pull request
Apr 21, 2021
We changed the way cv folds are assigned in h2oai#5345 This affects fold specification that doesn't start from 0, eg. 1, 2, 3 Old way was to use modulo operator resulting in effective fold assignment: 1, 2, 0 New way is to respect the fold order, resulting in fold assignment 0, 1, 2 (cherry picked from commit 8d5cc98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.