Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUBDEV-8257] 'cross_validation_metrics_summary' on MOJO Models Use Wrong Type for Columns #5601

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

mn-mikke
Copy link
Collaborator

@mn-mikke mn-mikke commented Aug 2, 2021

Flow UI before the change:
image

Flow UI after the change:
image

Serialized cross_validation_metrics_summary after the change:

      "cross_validation_metrics_summary": {
        "name": "Cross-Validation Metrics Summary",
        "description": "",
        "columns": [
          {
            "name": "",
            "type": "string",
            "format": "%s",
            "description": ""
          },
          {
            "name": "mean",
            "type": "float",
            "format": "%f",
            "description": "mean"
          },
          {
            "name": "sd",
            "type": "float",
            "format": "%f",
            "description": "sd"
          },
          {
            "name": "cv_1_valid",
            "type": "float",
            "format": "%f",
            "description": "cv_1_valid"
          },
          {
            "name": "cv_2_valid",
            "type": "float",
            "format": "%f",
            "description": "cv_2_valid"
          },
          {
            "name": "cv_3_valid",
            "type": "float",
            "format": "%f",
            "description": "cv_3_valid"
          }
        ],
        "rowcount": 8,
        "data": [
          [
            "mae",
            "mean_residual_deviance",
            "mse",
            "null_deviance",
            "r2",
            "residual_deviance",
            "rmse",
            "rmsle"
          ],
          [
            5.249874,
            42.981117,
            42.981117,
            4241.9937,
            -0.034168337,
            4329.0825,
            6.5461693,
            0.10129108
          ],
          [
            0.100146376,
            5.8517942,
            5.8517942,
            235.73878,
            0.03448591,
            293.41086,
            0.43952286,
            0.01012987
          ],
          [
            5.134717,
            38.70422,
            38.70422,
            4206.2153,
            0.0030673447,
            4180.0557,
            6.2212715,
            0.09408198
          ],
          [
            5.316587,
            49.649975,
            49.649975,
            4493.5767,
            -0.065009356,
            4667.0977,
            7.0462737,
            0.11287285
          ],
          [
            5.2983184,
            40.589157,
            40.589157,
            4026.1895,
            -0.040563,
            4140.094,
            6.370962,
            0.09691842
          ]
        ]
      }

@michalkurka
Copy link
Contributor

@mn-mikke please change the target branch to master - after our discussion I also changed the target release in the jira

@mn-mikke mn-mikke changed the base branch from rel-zipf to master August 5, 2021 10:27
@mn-mikke
Copy link
Collaborator Author

mn-mikke commented Aug 5, 2021

@mn-mikke please change the target branch to master

Done.

@michalkurka
Copy link
Contributor

@mn-mikke looks good, is there an easy way to use 6 decimals of precision instead of just 4?

@mn-mikke
Copy link
Collaborator Author

mn-mikke commented Aug 9, 2021

@michalkurka It seems that all float and double values in tables are hard-coded to have 4 decimal places after the floating point: https://github.com/h2oai/h2o-flow/blob/master/src/ext/modules/routines.coffee#L80

Copy link
Contributor

@michalkurka michalkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mn-mikke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants