Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUBDEV-8390: fix pyunit_PUBDEV_7185_GAM_mojo_ordinal.py failure #5844

Merged
merged 4 commits into from
Oct 26, 2021
Merged

PUBDEV-8390: fix pyunit_PUBDEV_7185_GAM_mojo_ordinal.py failure #5844

merged 4 commits into from
Oct 26, 2021

Conversation

wendycwong
Copy link
Contributor

@wendycwong wendycwong commented Oct 21, 2021 •
edited
Loading

This PR fixes the failure in https://h2oai.atlassian.net/browse/PUBDEV-8390

I changed the random dataset generation process to make sure there are enough real columns for gam_columns assignment.

@wendycwong wendycwong changed the base branch from master to rel-zizler October 21, 2021 17:28
maurever
maurever approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wendycwong !

@wendycwong wendycwong merged commit 230c682 into rel-zizler Oct 26, 2021
@wendycwong wendycwong deleted the PUBDEV_8390_GAM_ordinal_failure branch October 26, 2021 23:45
@h2o-ops-ro h2o-ops-ro mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurever maurever maurever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendycwong @maurever