PUBDEV-8416, PUBDEV-8417: AutoML propagate early stopping criteria to SEs + GLM #5951
+99
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2021 02:45
…ners+AutoML (otherwise we can't set the early stopping params on SEs)
sebhrusen
commented
Dec 11, 2021
| @@ -332,7 +336,6 @@ private void notifyModelListeners() { | |||
| public Job<M> trainModelOnH2ONode() { | |||
| if (error_count() > 0) | |||
| throw H2OModelBuilderIllegalArgumentException.makeFromBuilder(this); | |||
| this._input_parms = (P) this._parms.clone(); | |||
There was a problem hiding this comment.
@koniecsveta I think this one was a mistake as we're cloning AFTER validation, during which many parms are set or modified internally.
tomasfryda
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Looks good to me, thank you @sebhrusen !
I didn't find any reason why the line in trainModelOnH2ONode() shouldn't be removed - all code paths in h2o-3 seem to initialize _input_parms before it gets called (checked just by greping the method name) and I didn't find any other reason why it should be there.
|
We will revisit this after the holidays after reviewing the benchmarks more carefully. |
This was referenced May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://h2oai.atlassian.net/browse/PUBDEV-8416
https://h2oai.atlassian.net/browse/PUBDEV-8417