PUBDEV-8811: Fix leaderboard sorting #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfryda
commented
Aug 22, 2022
| @@ -91,8 +91,8 @@ public ValFrame apply(Env env, Env.StackHelp stk, AstRoot[] asts) { | |||
| .map(parameters -> parameters._nfolds) | |||
| .distinct() | |||
| .count() == 1; | |||
| final boolean allCV = Arrays.stream(models).allMatch(m -> ((Model) DKV.getGet(m))._parms._nfolds >= 2); | |||
There was a problem hiding this comment.
Checking nfolds causes issues when fold_column was used.
tomasfryda
commented
Aug 22, 2022
tomasfryda
changed the title
sebhrusen
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
@tomasfryda Please confirm that I understand correctly your changes with the sorting logic. Otherwise this looks good, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://h2oai.atlassian.net/browse/PUBDEV-8811
I noticed 2 bugs:
Leaderboard is not sorted by scoring_data but by some other logic (by the first available metrics from xval, valid, train) - this is problem when we want to see training leaderboard but it is sorted by xval metrics (if available).
Leaderboard is not sorted by sort_metric if it was already sorted by other metric