Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBDEV-8901 interaction constraints fix #6416

Merged

Conversation

valenad1
Copy link
Collaborator

@valenad1 valenad1 commented Nov 8, 2022

https://h2oai.atlassian.net/browse/PUBDEV-8901

I fixed the bug and to the best of my knowledge​ interaction constrains behave correctly now. If there is anybody fancy i deeper review of Interaction constrains, feel free to do so.

@valenad1 valenad1 changed the base branch from rel-zygmund to master November 8, 2022 17:04
@valenad1 valenad1 force-pushed the valenad-PUBDEV-8901-interaction-constraints-max-depth-fix branch from 590571b to 8594033 Compare November 9, 2022 15:43
@valenad1 valenad1 changed the base branch from master to rel-zygmund November 9, 2022 15:44
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot!

@valenad1 valenad1 merged commit 66b3404 into rel-zygmund Nov 18, 2022
@valenad1 valenad1 deleted the valenad-PUBDEV-8901-interaction-constraints-max-depth-fix branch November 18, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants