PUBDEV-8691 Single Decision Tree implementation #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenad1
requested changes
Jun 2, 2023
There was a problem hiding this comment.
There is couple of stuff that should be removed or improved before it goes public.
IMHO when we remove the stuff that I mention, we can have it in the codebase and polish it in different PR. There is no public documentation - only power user can try it with
from h2o.estimatorsimport H2ODecisionTreeEstimator
since there is no public documentation yet.
I would also consider to put it Expeprimental for the first implementation as SVM is.
@Override
public BuilderVisibility builderVisibility() { return BuilderVisibility.Experimental; }
TODOs I see for the differents PRs:
- scalability benchmarks
- Refactor DT API - the purpose of DT is to have nicer API than DTree
- Documentation in sphinx
- jupyter demo
And please rebase on current master, there are some conflict mentioned by github.
# Conflicts: # h2o-algos/src/main/java/hex/api/RegisterAlgos.java # h2o-r/H2O_Load.R # h2o-r/h2o-DESCRIPTION.template # h2o-r/scripts/h2o-r-test-setup.R
valenad1
reviewed
Jun 8, 2023
| // compute score for given point | ||
| CompressedDT tree = DKV.getGet(_output._treeKey); | ||
| DTPrediction prediction = tree.predictRowStartingFromNode(data, 0, ""); | ||
| // System.out.println(prediction.ruleExplanation); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the old one (#6182)
https://h2oai.atlassian.net/browse/PUBDEV-8691