-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chained conversation support #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjeblick
reviewed
Apr 25, 2023
maxjeblick
reviewed
Apr 25, 2023
maxjeblick
reviewed
Apr 25, 2023
maxjeblick
reviewed
Apr 25, 2023
llm_studio/python_configs/text_causal_language_modeling_config.py
Outdated
Show resolved
Hide resolved
maxjeblick
reviewed
Apr 25, 2023
maxjeblick
reviewed
Apr 25, 2023
llm_studio/python_configs/text_causal_language_modeling_config.py
Outdated
Show resolved
Hide resolved
maxjeblick
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for implementing this nice feature!
I've left some suggestions to rename variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues.
First, and foremost, it closes #17
It is now possible to add a
parent_column
which maps to a separateid
column in the data and then chains the samples.There are also two additional augmentation settings:
skip_parent_probability
randomly skips chained samples in trainingrandom_parent_probability
randomly prepends any random sample to a recordFor inference, full hierarchy is prepended, or nothing if not available
New data preparation was added to support this functionality.
Additionally, this PR fixes the following issues identified while implementing this PR:
force_embedding_gradients
was buggy and should be fixed nowIt adds also another new
add_prompt_answer_tokens
setting to manually specify whether to add separator tokens to the tokenizer.