-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #175, #204 #722
Merged
Fix #175, #204 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the same version of numpy, scipy everywhere * pytest==3.10.1
* remove debug print in a few places * add TODO
pseudotensor
approved these changes
Feb 19, 2019
Concern is segfaults are not solved. Please try demos in examples/py/demos |
Unable to reproduce segfaults(tested also all demos). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix memory leak with minimal changes. What was done:
WrappedPointer
is deleted by GC)Please let me know if I forget to fix/add something else(extra tests, documentation, etc)
We need more robust and clear logic when dealing with memory e.g. (not in this PR):
T** data
instead ofT* data
to detect that referenced pointer is freedCUDACHECK
everywhere, it's difficult and time consuming sometimes to point an exact place in the code