Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #175, #204 #722

Merged
merged 13 commits into from
Feb 21, 2019
Merged

Fix #175, #204 #722

merged 13 commits into from
Feb 21, 2019

Conversation

sh1ng
Copy link
Contributor

@sh1ng sh1ng commented Feb 14, 2019

The goal of this PR is to fix memory leak with minimal changes. What was done:

Please let me know if I forget to fix/add something else(extra tests, documentation, etc)

We need more robust and clear logic when dealing with memory e.g. (not in this PR):

  • memory ownership(current implementation vague a bit)
  • use T** data instead of T* data to detect that referenced pointer is freed
  • cover with test cases scenarios when copying memory: cpu->gpu, gpu->gpu
  • use CUDACHECK everywhere, it's difficult and time consuming sometimes to point an exact place in the code

@sh1ng sh1ng self-assigned this Feb 14, 2019
@sh1ng sh1ng changed the title Fix 175, 204 Fix #175, #204 Feb 18, 2019
@pseudotensor
Copy link
Collaborator

Concern is segfaults are not solved. Please try demos in examples/py/demos

@sh1ng
Copy link
Contributor Author

sh1ng commented Feb 21, 2019

Unable to reproduce segfaults(tested also all demos).
Found out that memory still not completely released even after del model, but it's not growing. I'm going to continue in separate PR.

@sh1ng sh1ng merged commit fe5b7a3 into master Feb 21, 2019
@sh1ng sh1ng deleted the fix_175 branch February 21, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants