Draft: add tests for generator #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add semicolons - remove blank line before the closing bracket
czabaj
commented
Mar 7, 2022
generator_test.go
Outdated
| } | ||
| return plugin_go.CodeGeneratorRequest{ | ||
| ProtoFile: []*descriptorpb.FileDescriptorProto{ | ||
| {Syntax: &syntax, EnumType: file.EnumType, MessageType: file.MessageType}, |
There was a problem hiding this comment.
I struggle with passing of the pointers to the descriptorpb, it requires all values as a pointers, which complicates the logic.
E.g. here I would like to pass a
{Syntax: "proto3"
but that yields an error, as the Syntax expects a pointer, and I cannot create a string pointer in-place, right? So every time I want to pass a pointer, I need to declare a variable for the value which is verbose.
Is there some trick how to create e.g. a string and pass that immediately as a pointer?
There was a problem hiding this comment.
Found a solution, using a gox package. https://stackoverflow.com/a/30716481/2508019
czabaj
commented
Mar 7, 2022
| baz := "baz" | ||
| tNumber := descriptorpb.FieldDescriptorProto_TYPE_DOUBLE | ||
| tString := descriptorpb.FieldDescriptorProto_TYPE_SFIXED64 | ||
| tBool := descriptorpb.FieldDescriptorProto_TYPE_BOOL |
There was a problem hiding this comment.
More ad-hoc variables just to obtain pointers to them.
|
Closing as obsoleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make this generator comply with the proto3 JSON canonical encoding. To make this happen, I need a test suite that the project currently lacks.
I'm fairly new to Go lang so I struggle with the most basic things, feel free to correct me or advise a better approach to the code.