[SW-1421] Integrate H2O 3.26.0.1 #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
commented
Jul 16, 2019
| @@ -175,7 +175,8 @@ object H2OMOJOModel extends H2OMOJOReadable[PyH2OMOJOModel] with H2OMOJOLoader[P | |||
| val is = new ByteArrayInputStream(mojoData) | |||
| val reader = MojoReaderBackendFactory.createReaderBackend(is, MojoReaderBackendFactory.CachingStrategy.MEMORY) | |||
|
|
|||
| val modelOutputJson = JsonModelDescriptorReader.parseModelJson(reader).getAsJsonObject("output") | |||
|
|
|||
| val modelOutputJson = ModelJsonReader.parseModelJson(reader).getAsJsonObject("output") | |||
There was a problem hiding this comment.
was moved in H2O to ModelJsonReader
jakubhava
commented
Jul 16, 2019
| * @param destination directory where the logs will be downloaded | ||
| */ | ||
| def downloadH2OLogs(destination: URI, logContainer: LogArchiveContainer): URI = { | ||
| val workersLogs = getLogsFromWorkers(logContainer) |
There was a problem hiding this comment.
I created PR on H2O h2oai/h2o-3#3698 which would allow us to remove the logic for downloading logs from SW and use directly H2O implementation. Right now this is duplication code in H2O
mn-mikke
approved these changes
Jul 16, 2019
| // Close the full zip file. | ||
| zos.close() | ||
| val finalArchiveByteArray = try { | ||
| val method = classOf[RequestServer].getDeclaredMethod("archiveLogs", classOf[LogArchiveContainer], |
There was a problem hiding this comment.
It would be nice to change the archiveLogs method to public and call the method directly in a different PR.
There was a problem hiding this comment.
Yup -> h2oai/h2o-3#3698
| try { | ||
| baos.writeTo(outputStream) | ||
| outputStream.write(finalArchiveByteArray) | ||
| } | ||
| finally { | ||
| if (outputStream != null) outputStream.close() |
There was a problem hiding this comment.
I know that this is unrelated to this PR, but can outputStreamever be null?
There was a problem hiding this comment.
Good catch, we can remove this check!
jakubhava
added a commit
that referenced
this pull request
Jul 16, 2019
(cherry picked from commit c795a52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.