Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow frame cards to be displayed without margin/padding #495

Closed
lo5 opened this issue Jan 15, 2021 · 2 comments · Fixed by #1735
Closed

Allow frame cards to be displayed without margin/padding #495

lo5 opened this issue Jan 15, 2021 · 2 comments · Fixed by #1735
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@lo5
Copy link
Member

lo5 commented Jan 15, 2021

Would be useful when embedding other Wave or third-party pages.
Currently the card has its own padding, combined with the padding/margin of the embedded page.
@lo5 lo5 added ui Related to UI feature Feature request labels Jan 15, 2021
@mturoci mturoci added the good first issue Contributions welcome! label Jan 18, 2021
@lo5 lo5 removed the good first issue Contributions welcome! label Mar 25, 2021
@lo5
Copy link
Member Author

lo5 commented Mar 25, 2021

Blocks #49

@mturoci mturoci added the good first issue Contributions welcome! label Sep 12, 2022
@Nicolapps Nicolapps mentioned this issue Nov 30, 2022
Closed
@Nicolapps
Copy link
Contributor

I’m working with @sherrychen2, @monal20, and @kitty3190 on a PR for this issue (and also #1645, #372, and #1535) as part of a Software Engineering class assignment.

This was referenced Nov 30, 2022
Open
Closed
@kitty3190 kitty3190 mentioned this issue Dec 5, 2022
Merged
mturoci pushed a commit that referenced this issue Dec 9, 2022
@kitty3190
feat: Allow users to remove paddings on frame cards #495 (#1735)
2b16927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow users to remove paddings on frame cards kitty3190/wave
3 participants
@lo5 @Nicolapps @mturoci