Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.combobox returns different types of values #1615

Closed
MartinBarus opened this issue Sep 7, 2022 · 3 comments · Fixed by #1616
Closed

ui.combobox returns different types of values #1615

MartinBarus opened this issue Sep 7, 2022 · 3 comments · Fixed by #1616
Assignees
Labels
bug Bug in code ui Related to UI

Comments

@MartinBarus
Copy link

sometimes the return value is string (when selected by dropdown), sometimes, if you type some text in it, list is returned instead, for the same instance.

You can also use this tutorial to reproduce https://wave.h2o.ai/docs/examples/combobox

@MartinBarus MartinBarus added the bug Bug in code label Sep 7, 2022
@aalencar aalencar self-assigned this Sep 7, 2022
@mturoci mturoci added the ui Related to UI label Sep 8, 2022
@aalencar
Copy link
Contributor

aalencar commented Sep 8, 2022

@MartinBarus I managed to reproduce it on Wave 0.22 but not on master (with the latest changes, next release).
It looks like it was caused by #1327 and has been unintentionally fixed by #1538

0.22

Screen.Recording.2022-09-08.at.11.11.20.mov

After PR 1538 - latest changes

Screen.Recording.2022-09-08.at.11.10.05.mov

Currently checking what was the bug and will write some tests to ensure it won't happen again.

cc: @mturoci

@mturoci
Copy link
Collaborator

mturoci commented Sep 8, 2022

@aalencar I managed to repro it yesterday on master. The problem is that your combobox implementation relies on hitting enter at the end of typing. Instead, we should update wave.args continually as user types (same behavior as textbox).

Repro steps should be something like:

  • Run combobox.py example.
  • Write something to the first combobox.
  • Click submit button.
  • See the list in q.args.

@mturoci
Copy link
Collaborator

mturoci commented Sep 8, 2022

I checked wrong branch, please ignore my last comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants