-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow users to remove paddings on frame cards #1735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kitty3190!
Based on your screenshots, it seems like it might be a good idea to also not display the title (even if specified) if the padding is turned off. This way, the whole frame card should be occupied purely with the content
(be it an HTML or 3rd party site link).
Make sure to reflect the above in docstrings as well.
Thanks for the review @mturoci! I addressed the issues in my latest commit and updated the documentation above in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I forgot the docs last time. Can you please add this to both frame.md
files? Once done, it's good to be merged.
Co-authored-by: mturoci <64769322+mturoci@users.noreply.github.com>
Thanks @mturoci! I've added documentation in the |
Added a parameter called
compact
in theState
interface offrame.tsx
. Users can specify whether they want the frame cards to have title and paddings or not.compact
defaults toFalse
.Example:
Frame card with no padding specified:
The changes are reflected above. The first frame card with default padding (
compact
not specified), the second frame card with padding specified, and the third frame card with no padding specified.The code used for testing the changes above:
This pull request closes #495.