New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add urllib3 to setup.ps1 #2290

Merged

mturoci merged 1 commit into main from fix/nightly-py-tests-windows

Mar 14, 2024

Contributor

marek-mihok commented Mar 14, 2024

The PR fulfills these requirements: (check all the apply)

It's submitted to the main branch.
When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
If changes were made to ui folder, unit tests (make test) still pass.
New/updated tests are included

Fixes failing nightly py tests on windows after #2286.


          fix: add urllib3 to setup.ps1

bb4766a

marek-mihok requested review from lo5 and mturoci as code owners

March 14, 2024 10:44

mturoci merged commit 5fd6aa5 into main

2 checks passed

mturoci deleted the fix/nightly-py-tests-windows branch

March 14, 2024 10:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet