Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing patch #13

Merged
merged 4 commits into from
Nov 30, 2019
Merged

Testing patch #13

merged 4 commits into from
Nov 30, 2019

Conversation

h4110w33n
Copy link
Owner

This is to correct two bugs that were caught in the TravisCI tests.

  1. Windows has been pulled from the TravisCI tests since the TravisCI provided VM was failing due to a connectivity issue pretty consistently. Long term goal will be to bring this back. See: Bring back Windows testing #12
  2. The returned object from the API is crazy large (bigger than requests handles by default) for get_market_info and get_exchange_info when no arguments are provided. All tests are now performed with sane arguments.

@h4110w33n
Testing Patch-1 - cleaning over specificity
fb32ad4 
The return output from most recent builds were failing due to
truncation for the output, which is an issue for the testing
script, not the library itself.

Example failure:
https://travis-ci.org/h4110w33n/coinmetrics/jobs/617497095
@h4110w33n
fixing windows python versioning
d3995ae
@h4110w33n
removing windows for the time being
ccd1e09 
Windows support on TravisCI is technically in beta
so i'm not that bothered. We'll bring it back once
it is a more mature option.
@pep8speaks

This comment has been minimized.

Sign in to view
@h4110w33n h4110w33n mentioned this pull request Nov 30, 2019
Open
@codecov-io

This comment has been minimized.

Sign in to view
@h4110w33n h4110w33n changed the title Test patch Testing patch Nov 30, 2019
@h4110w33n h4110w33n self-assigned this Nov 30, 2019
@h4110w33n
Copy link
Owner Author

build #80 has cleared, so this is getting merged.

https://travis-ci.org/h4110w33n/coinmetrics/builds/618996729

@h4110w33n h4110w33n merged commit 09a3c41 into master Nov 30, 2019
@h4110w33n h4110w33n deleted the test-patch-1 branch March 7, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h4110w33n h4110w33n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h4110w33n @pep8speaks @codecov-io