Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keep_base_url=True to support different response domain #24

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Lukas-Heiligenbrunner
Copy link
Contributor

When gitlab responses a different base domain it is used by the gitlab lib.
In my case this was somehow wrong and setting keep_base_url=True fixed it.
With that always the env var is used.
This should fix #15
Thanks for the great project by the way.

@h44z h44z merged commit 39394a0 into h44z:master Jul 4, 2024
@h44z
Copy link
Owner

h44z commented Jul 4, 2024

thanks =)

@Voriaz
Copy link

Voriaz commented Aug 23, 2024

Hello,

Just a side note on this.

I noticed that the docker image provided (with the Dockerfile) is using Python3.6 which implies using python-gitlab 2.10.
The small problem is that python-gitlab 2.10 doesn't support keep_base_url=True.
I tried to bump the docker image to Python 3.12, but I had errors with self signed certificates and it was impossible to disable cert verification globally.
I'll see if I have time to check this later and will submit a new PR.

From now, if one want to use docker image as is, he must remove keep_base_url=True from migrate.py.

Thanks,

A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Well done!
3 participants