Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature posix drivers loading #151

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Conversation

Wellinator
Copy link
Contributor

It load the fileXio and iomanX needed for reading/writing from FS in the PS2.
It fixes the writeLogsToFile function in the real hardware using the USB drivers as well.

@Wolf3s
Copy link
Contributor

Wolf3s commented Feb 1, 2023

It load the fileXio and iomanX needed for reading/writing from FS in the PS2. It fixes the writeLogsToFile function in the real hardware using the USB drivers as well.

Good feature it maybe solver the problems of the modules loding on usb

Copy link
Owner

@h4570 h4570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Whats up buddy, how its going?

Please confirm if:

  • Demo sample was tested on real hardware with these changes
  • Demo sample was tested on PCSX2 with these changes

Proofs are appreciated.

@@ -27,6 +27,7 @@ class IrxLoader {
void loadSio2man(const bool& verbose);
void loadPadman(const bool& verbose);
void loadLibsd(const bool& verbose);
void loadPOSIX(const bool& verbose);
Copy link
Owner

@h4570 h4570 Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe loadIO()? I think that POSIX name is too generic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good name, I'll refactor this.
The DEMO was tested in the PCSX2 but no in the real hardware.
I'll certify it's working on both of them beforo update the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good name, I'll refactor this. The DEMO was tested in the PCSX2 but no in the real hardware. I'll certify it's working on both of them beforo update the PR

I totally forgot about these pending checks. I'll test in the real hardware and comeback with the results

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

Copy link
Contributor

@israpps israpps Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be called load extended IO or something...

The POSIX trick is caused by the libcglue library.

fileXio and iomanX are just eXtended I/O modules, that co-exist with their stock versions (rom0:IOMAN, rom0:FILEIO)

Would be cool to have progress on this, since i'll be helping @Wolf3s to add iHDD Support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wellinator over here ⬆️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys! Thx for the suggestions.
Gonna finish it rn.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a new branch based on yours, i think you don't need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing in the real hardware

@Wellinator
Copy link
Contributor Author

20231111_121121
20231111_122602
Screenshot_1
Screenshot_2

Okay! All nice.
I've tested in the PCSX2 and Real Hardware
@h4570

@h4570
Copy link
Owner

h4570 commented Nov 11, 2023

@Wellinator
Cool 🚀

Could you please change the loadPOSIX() function name?
So I will merge PR.

Thanks!

@Wellinator
Copy link
Contributor Author

Sure, no problem

@Wellinator
Copy link
Contributor Author

I've renamed to loadIO as you suggested a while ago!

@h4570 h4570 merged commit 676ac34 into h4570:master Nov 11, 2023
2 checks passed
@Wellinator Wellinator deleted the feature/posix-drivers branch January 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants