Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "NFT Card" variant remains selected after changing to a non-NFT avatar #5

Closed
h4l opened this issue Oct 16, 2022 · 0 comments · Fixed by #6
Closed

The "NFT Card" variant remains selected after changing to a non-NFT avatar #5

h4l opened this issue Oct 16, 2022 · 0 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@h4l
Copy link
Owner

h4l commented Oct 16, 2022

Headgear tries and fails to render a regular avatar with the NFT Card image variant in the following situation:

  • Select an NFT avatar in the Avatar builder
  • Open Headgear and view the NFT Card image
  • Select a non-NFT avatar in the Avatar Builder
  • Re-open Headgear
  • Headgear tries to show the non-NFT avatar as an NFT Card, which fails (albeit nicely with an error message in the main view)

image
@h4l h4l added the bug Something isn't working label Oct 16, 2022
h4l added a commit that referenced this issue Oct 19, 2022
@h4l
fix: prevent non-NFT avatars being rendered as NFT Cards
1dabadc 
Non-NFT avatars were being rendered with the NFT Card style if the NFT
Card style option was restored from storage and the current Avatar was
not an NFT Avatar. The style now defaults to the Standard style if an
incompatible or unimplemented style is requested.

This fixes #5
@h4l h4l mentioned this issue Oct 19, 2022
Merged
h4l added a commit that referenced this issue Oct 19, 2022
@h4l
fix: prevent non-NFT avatars being rendered as NFT Cards
79dacd3 
Non-NFT avatars were being rendered with the NFT Card style if the NFT
Card style option was restored from storage and the current Avatar was
not an NFT Avatar. The style now defaults to the Standard style if an
incompatible or unimplemented style is requested.

This fixes #5
@h4l h4l closed this as completed in 21b8ae6 Oct 20, 2022
h4l added a commit that referenced this issue Oct 20, 2022
@h4l
fix: prevent non-NFT avatars being rendered as NFT Cards
8de8608 
Non-NFT avatars were being rendered with the NFT Card style if the NFT
Card style option was restored from storage and the current Avatar was
not an NFT Avatar. The style now defaults to the Standard style if an
incompatible or unimplemented style is requested.

This fixes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent non-NFT avatars being rendered as NFT Cards h4l/headgear
1 participant
@h4l