Fix #24 #33
Merged
Fix #24 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems something inside libav is not behaving properly. Either MKV is not well-defined in terms of supported formats or
av_codec_get_tag2should not be used like that. Maybe it doesn't support getting tags for subtitle streams, I have no idea really. The fact is, it prevents adding aubtitles to an MKV container and it's wrong so I removed that check. It's redundant anyway because right after adding a stream we check the result for NULL, so if it didn't work for whatever reason we'dthrow_if.