Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always propagate use state #75

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Always propagate use state #75

merged 3 commits into from
Jan 31, 2024

Conversation

liamhuber
Copy link
Contributor

Closes #74

jan-janssen
jan-janssen approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@liamhuber liamhuber mentioned this pull request Jan 26, 2024
Merged
3 tasks
@liamhuber
Copy link
Contributor Author

@jan-janssen do you have merge permission or is this the time to bring @larsoner in here?

@jan-janssen
Copy link
Member

@jan-janssen do you have merge permission or is this the time to bring @larsoner in here?

While I have permission, I would prefer @larsoner to take a look as well.

@larsoner larsoner merged commit 5cad45f into h5io:main Jan 31, 2024
6 checks passed
@larsoner
Copy link
Member

Thanks @liamhuber !

@liamhuber liamhuber deleted the always_propagate_use_state branch January 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_state does not propagate to recursive _triage_write calls
3 participants
@liamhuber @jan-janssen @larsoner