Fix full player height for Chromium based browsers if fitToWrapper is set #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When using the full player mode with the fitToWrapper option, Chromium based browsers like Chrome, Edge or Opera will set a height of 0 unless the audio content's wrapper has an explicit size set. That problem occurs in Column, for example - audio content in full player mode with fitToWrapper set will not show on Chrome.
Fix: Apply Chromium's default height for audio elements (54 px) if a Chromium based browser is used in full player mode with the fitToWrapper option set.
Please note: Yes, it's kind of counter-intuitive to set an absolute height when the option is called fitToWrapper, but other browsers like Safari or Firefox have a fixed height anyway and will never scale the audio player to the full height of the wrapper. On the plus side, adding the height to this very audio library instead of setting it in every content type makes developing for H5P easier.