Add xapi video verbs #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @KirkJohnson, I've made an issue for this pull request and h5p/h5p-video#17 to be reviewed and merged: |
|
Awesome! Thank you. We hope this will be acceptable to your core team!
…On Fri, Nov 24, 2017 at 4:29 AM, Timothy Lim ***@***.***> wrote:
Nice work @KirkJohnson <https://github.com/kirkjohnson>, I've made an
issue for this pull request and h5p/h5p-video#17
<h5p/h5p-video#17> to be reviewed and merged:
https://h5ptechnology.atlassian.net/browse/HFP-1779
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AILQWDoUoWCUGLnufNN82EII6K1cQbc5ks5s5tK4gaJpZM4QoLP7>
.
--
*Kirk Johnson*
IT Specialist, Distance Course Design & Consulting (DCDC)
Office: (808) 956-0000 | Web: dcdc.coe.hawaii.edu
|
|
This pull request can be deleted; we have incorporated feedback from @falcon-git, making a core change unnecessary: The verb URL and name for the new video verbs are now set in h5p-video:scripts/x-api.js along with the rest of the xAPI statement. Those changes are still pending in a different pull request: h5p/h5p-video#17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add xAPI verbs for video events (play, pause, finished, seeked) to the list of allowed xAPI verbs. Note: another pull request against h5p-video will implement this feature.