Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(example): lowercase data-testId #39

Merged
merged 1 commit into from
May 17, 2021
Merged

docs(example): lowercase data-testId #39

merged 1 commit into from
May 17, 2021

Conversation

bigsaigon333
Copy link
Contributor

@bigsaigon333 bigsaigon333 commented May 16, 2021 •
edited
Loading

Hi @JaeYeopHan!

I just posted a tiny issue(#40)!

Please kindly review my PR.

Before

Before

After

After

@bigsaigon333 bigsaigon333 mentioned this pull request May 16, 2021
Closed
JaeYeopHan
JaeYeopHan approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@JaeYeopHan JaeYeopHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@JaeYeopHan JaeYeopHan merged commit 371c52f into h6s-dev:main May 17, 2021
@JaeYeopHan
Copy link
Collaborator

@all-contributors please add @bigsaigon333 for maintenance

@allcontributors allcontributors bot mentioned this pull request May 17, 2021
Merged
@allcontributors
Copy link
Contributor

@JaeYeopHan

I've put up a pull request to add @bigsaigon333! 🎉

@bigsaigon333 bigsaigon333 deleted the pr/data-testid branch August 24, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaeYeopHan JaeYeopHan JaeYeopHan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigsaigon333 @JaeYeopHan