Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis build #63

Merged
merged 1 commit into from
Jul 7, 2013
Merged

fix travis build #63

merged 1 commit into from
Jul 7, 2013

Conversation

mreiferson
Copy link
Contributor

n/t

@geetarista
Copy link
Contributor

Is pushd and popd necessary? I thought travis always runs the test script from $TRAVIS_BUILD_DIR.

Either way, glad to have passing tests again. 😄

@mreiferson
Copy link
Contributor Author

hah, really all that's necessary is a cd $TRAVIS_BUILD_DIR, I suppose pushd/popd are habits of mine.

For some background... travis recently changed their go build environment to copy the repository into a properly built GOPATH (which folks already tended to be doing manually in their travis.yml script). The problem is that by default, travis will run go test ./... in the root of GOPATH, rather than in TRAVIS_BUILD_DIR so it runs tests for your repository as well as any installed dependencies.

I'm fairly certain they're aware of this, but these changes should be future proof if/when they decide to change that behavior.

@geetarista
Copy link
Contributor

Thanks for the update. I wasn't aware that their environment acted like that.

@dgryski
Copy link

dgryski commented Jul 7, 2013

Can somebody merge this to make our little travis badge go 'green' again?

mreiferson added a commit that referenced this pull request Jul 7, 2013
@mreiferson mreiferson merged commit 709ed4f into ha:master Jul 7, 2013
@pythonmobile
Copy link

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants