Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package "tests" is included in the distribution #23

Closed
anthrax-0 opened this issue Feb 7, 2020 · 3 comments
Closed

Package "tests" is included in the distribution #23

anthrax-0 opened this issue Feb 7, 2020 · 3 comments

Comments

@anthrax-0
Copy link

PyPi version 1.0.0 of the "utils" includes also "tests" package which creates naming conflicts in many places. I suggest changing setup.py as described here (using "exclude"): https://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages should help.

@haaksmash
Copy link
Owner

@anthrax-0 thanks for the report and helpful link!

Seems like you're thinking

packages=find_packages(),
could become

packages=find_packages(exclude=[*.tests]),

? PRs are always welcome 😉

@haaksmash haaksmash mentioned this issue Feb 8, 2020
@haaksmash
Copy link
Owner

@anthrax-0 hopefully the new patch version solves the problem! Feel free to re-open this issue if not.

@anthrax-0
Copy link
Author

I think in pyutils case exclude should look like this:
packages=find_packages(exclude=["tests", "tests.*"]),

mahtin added a commit to mahtin/pyutils that referenced this issue Jan 5, 2024
haaksmash added a commit that referenced this issue Jan 6, 2024
#28 (and #23) a fix to stop .../tests/* being installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants