-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Flask web server with zege countdown functionality #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In app.py, please add a newline at the end of the file.
- In countdown.py, please update the function name from "run_zege_countdown" to "zege_countdown" on line 24.
- In templates/index.html, please add a newline at the end of the file.
sweep-ai
bot
changed the title
[DRAFT] Implement Flask web server with zege countdown functionality
Implement Flask web server with zege countdown functionality
Jul 24, 2023
Sweep: add javascripts in index.html, implementing the zege countdown logic and update the text in "countdown" element |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a Flask web server with a single webpage that displays a "zege countdown" automatically. The countdown logic from the
countdown.py
file has been extracted into a separate file namedcountdown_logic.py
and modified to rename the function tozege_countdown
.Changes Made
app.py
to implement the Flask web server and define the necessary routes.templates/index.html
to display the countdown on the webpage.countdown.py
file to extract therun_zege_countdown
function intocountdown_logic.py
and renamed the function tozege_countdown
.Testing
Related Issue
Create a web server based on flask framework with a single webpage. The page should show a "zege countdown" automatically. Please refer to countdown.py for the logic of "zege countdown" and do not modify countdown.py
Fixes #6.
To checkout this PR branch, run the following command in your terminal: