Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php plan should include composer #325

Closed
igalic opened this issue Dec 7, 2016 · 6 comments
Closed

php plan should include composer #325

igalic opened this issue Dec 7, 2016 · 6 comments

Comments

@igalic
Copy link
Contributor

igalic commented Dec 7, 2016 •
edited
Loading

composer is php's package manager.
As such it should be part of the php package, since it's pretty much essential for building most modern php applications.

here's how to install it: https://getcomposer.org/doc/faqs/how-to-install-composer-programmatically.md
@eeyun
Copy link
Contributor

eeyun commented Dec 8, 2016

I honestly don't know enough about php myself but I think this makes sense.

Would there ever be a case for a php dev where they would want composer separate from php?

@igalic igalic mentioned this issue Dec 8, 2016
Closed
@igalic
Copy link
Contributor Author

igalic commented Dec 8, 2016

in trying to do this ⬆️, i just discovered: #327.

@igalic
Copy link
Contributor Author

igalic commented Dec 8, 2016 •
edited
Loading

@eeyun composer doesn't work without php.
otoh: composer would work with either php5 or php(7), so there's an argument to be had for not integrating it.

smith pushed a commit that referenced this issue Dec 8, 2016
Updates to php5 plan
29423de 
* Stop doing the thing where we symlink into /usr/bin for xml2-config;
  found a way to do this with a variable
* Add composer (run it with `hab pkg exec core/php5 composer`)
* Add curl, openssl, zlib, and xmlrpc support

Fixes #325
Fixes #327

Signed-off-by: Nathan L Smith <smith@chef.io>
@smith smith mentioned this issue Dec 8, 2016
Merged
smith pushed a commit that referenced this issue Dec 9, 2016
Updates to php5 plan
003e0fe 
* Stop doing the thing where we symlink into /usr/bin for xml2-config;
  found a way to do this with a variable
* Add glibc as a direct, rather than transitive dep, because it is
* Add composer (run it with `hab pkg exec core/php5 composer`)
* Add curl, exif, fpm, mbstring, opcache, openssl, zlib, and xmlrpc support
* Add sbin to bin_dirs (that's where php-fpm goes)

Fixes #325
Fixes #327

Signed-off-by: Nathan L Smith <smith@chef.io>
smith pushed a commit that referenced this issue Dec 9, 2016
Updates to php5 plan
950e74a 
* Stop doing the thing where we symlink into /usr/bin for xml2-config;
  found a way to do this with a variable
* Add glibc as a direct, rather than transitive dep, because it is
* Add composer (run it with `hab pkg exec core/php5 composer`)
* Add curl, exif, fpm, mbstring, opcache, openssl, zlib, and xmlrpc support
* Add sbin to bin_dirs (that's where php-fpm goes)

Fixes #325
Fixes #327

Signed-off-by: Nathan L Smith <smith@chef.io>
@themightychris
Copy link
Contributor

It should be separate, there is lots to do with PHP without composer and they don't share maintainers or release cycle

@igalic
Copy link
Contributor Author

igalic commented Dec 28, 2016

alpine has a separate composer as well, whereas npm is built-in with node because they are relatively tightly coupled.

@smith
Copy link
Contributor

smith commented Jan 8, 2017

Closing this, as it seems it would be better to ship composer separately.

@smith smith closed this as completed Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @themightychris @igalic @eeyun