Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 0.26.1 to build windows harts and then use current studio to test that it works #2842

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Jul 28, 2017

This does 2 things:

  • Uses 0.26.1 to build the windows harts in appveyor because 0.27.0 will panic. We should use latest after 0.27.1 releases.
  • Once the new studio is built. use that new studio to build the rest of the components. This should have been working before but had a bug because the built executable was copies one level too shallow. This should prevent a panicking studio from releasing again.

Signed-off-by: Matt Wrock matt@mattwrock.com

… it works

Signed-off-by: Matt Wrock <matt@mattwrock.com>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock
Copy link
Contributor Author

mwrock commented Jul 28, 2017

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 25cb200 into master Jul 28, 2017
@thesentinels thesentinels deleted the fix_deploy branch July 28, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants